Pull Request Test Coverage Report for Build 17216182984

Details

• 100 of 1839 (5.44%) changed or added relevant lines in 29 files are covered.
• 41 unchanged lines in 6 files lost coverage.
• Overall coverage decreased (-4.0%) to 30.38%

Totals
Change from base Build 16882556085:	-4.0%
Covered Lines:	4093
Relevant Lines:	11850

💛 - Coveralls

So I attempted to review this but I think you have a massive number of thread safety issues. I got thousands of exceptions - some concurrent modification, some sequence contained no matching element, and various others - while analyzing, and then when it finished and tried to write the assemblies, I got an AggregateException with 2588 inner exceptions, most of which were either MemberNotImportedException, or IL_[offset] references an offset that is not present in the method body.

From a quick look, you're using one _ilGenerator in AsmResolverDllOutputFormatIlRecovery.FillMethodBody, but that method is called in parallel so you've got multiple calls to it at once, which it can't handle - e.g. it maintains an _importer field which is being overwritten constantly, so methods are being imported into the wrong modules. Seems you'll have to pass that through.

The control flow graphs I did get (I uncommented the line which wrote them, so that I could evaluate the decompilation in at least some way) looked promising, though they were much more complex and I didn't have much time to familiarise myself with the string representations you were using.

For reference, I was attempting to decompile AUDICA.

I forgot to try this in non debug mode so stuff was not actually parallel, should be fixed now